Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod is missing replace for k8s.io/endpointslice #2008

Closed
RomanBednar opened this issue Oct 12, 2023 · 0 comments · Fixed by #2014
Closed

go.mod is missing replace for k8s.io/endpointslice #2008

RomanBednar opened this issue Oct 12, 2023 · 0 comments · Fixed by #2014

Comments

@RomanBednar
Copy link
Contributor

What happened:

Since this repo depends on k8s.io/kubernetes it is required to replace all modules in staging, even though they're not a real dependency of this repo. Discussion here: kubernetes/kubernetes#79384 (comment)

k/k recently added k8s.io/endpointslice module: kubernetes/kubernetes@22c6678

and it is now causing go list to fail:

go list -mod=readonly -m all 
go: k8s.io/endpointslice@v0.0.0: invalid version: unknown revision v0.0.0

What you expected to happen:

go list should pass

How to reproduce it:

Run go list -mod=readonly -m all in master.

Anything else we need to know?:

This was found by OpenShift CI during rebase where we run dependency verification, I believe adding this line to go.mod should fix the issue:

k8s.io/endpointslice => k8s.io/endpointslice v0.28.1

Environment:

  • CSI Driver version: master
  • Kubernetes version (use kubectl version): n/a
  • OS (e.g. from /etc/os-release): n/a
  • Kernel (e.g. uname -a): n/a
  • Install tools: n/a
  • Others: n/a
RomanBednar added a commit to RomanBednar/azure-disk-csi-driver that referenced this issue Oct 12, 2023
@RomanBednar
UPSTREAM: <carry>: add replace for k8s.io/endpointslice module
702e871 
Can be dropped if upstream adds this replace to go.mod:

k8s.io/endpointslice => k8s.io/endpointslice v0.28.1

Reported upstream: kubernetes-sigs#2008

Commit fixes verify-deps check which was failing with:

go: k8s.io/endpointslice@v0.0.0: invalid version: unknown revision v0.0.0
ERROR: go list -mod=readonly -m all failed with the message listed above.
Cachito used in ART builds will fail to resolve dependencies offline.
Typically, a pinned version is missing in go.mod, e.g.:
    replace k8s.io/foo => k8s.io/foo v0.26.0
@andyzhangx andyzhangx mentioned this issue Oct 13, 2023
Merged
4 tasks
RomanBednar added a commit to RomanBednar/azure-disk-csi-driver that referenced this issue Oct 16, 2023
@RomanBednar
UPSTREAM: <carry>: add replace for k8s.io/endpointslice module
1ee13ca 
Can be dropped if upstream adds this replace to go.mod:

k8s.io/endpointslice => k8s.io/endpointslice v0.28.1

Reported upstream: kubernetes-sigs#2008

Commit fixes verify-deps check which was failing with:

go: k8s.io/endpointslice@v0.0.0: invalid version: unknown revision v0.0.0
ERROR: go list -mod=readonly -m all failed with the message listed above.
Cachito used in ART builds will fail to resolve dependencies offline.
Typically, a pinned version is missing in go.mod, e.g.:
    replace k8s.io/foo => k8s.io/foo v0.26.0
RomanBednar added a commit to RomanBednar/azure-disk-csi-driver that referenced this issue Oct 18, 2023
@RomanBednar
UPSTREAM: <carry>: add replace for k8s.io/endpointslice module
dde1f01 
Can be dropped if upstream adds this replace to go.mod:

k8s.io/endpointslice => k8s.io/endpointslice v0.28.1

Reported upstream: kubernetes-sigs#2008

Commit fixes verify-deps check which was failing with:

go: k8s.io/endpointslice@v0.0.0: invalid version: unknown revision v0.0.0
ERROR: go list -mod=readonly -m all failed with the message listed above.
Cachito used in ART builds will fail to resolve dependencies offline.
Typically, a pinned version is missing in go.mod, e.g.:
    replace k8s.io/foo => k8s.io/foo v0.26.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup: fix k8s.io/endpointslice dependency andyzhangx/azuredisk-csi-driver
1 participant
@RomanBednar