-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ReservedDataDiskSlotNum to helm-chart #2383
Conversation
|
Welcome @ClementLachaussee! |
Hi @ClementLachaussee. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hey @andyzhangx ! |
/ok-to-test |
4973c6b
to
f8a3db2
Compare
Signed-off-by: ClementLachaussee <clement_lachaussee@ext.carrefour.com>
f8a3db2
to
bb9a4ff
Compare
/retest |
1 similar comment
/retest |
@andyzhangx do you know when this can be added to a release ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, ClementLachaussee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ClementLachaussee: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@ClementLachaussee I am adding this chart config into v1.29.7 release since it does not have that ReservedDataDiskSlotNum assign bug: |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The option is not available in the HelmChart, and the option is never given from the DriverOptiont struct to Driver struct.
Which issue(s) this PR fixes:
Fixes #2382
Special notes for your reviewer: