Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conformance tests for UDPRoute & TCPRoute #81

Open
2 tasks
shaneutt opened this issue Mar 13, 2023 · 12 comments
Open
2 tasks

Add conformance tests for UDPRoute & TCPRoute #81

shaneutt opened this issue Mar 13, 2023 · 12 comments
Labels
area/ci area/tests blocked lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. on-hold priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@shaneutt
Copy link
Member

shaneutt commented Mar 13, 2023

Part of the purpose of this project was to help mature UDPRoute and TCPRoute in upstream Gateway API.

Part of that maturity is a need for conformance tests which multiple implementations can subscribe to. The purpose of this task is to add the conformance test suite for Gateway API to this repository, resolve kubernetes-sigs/gateway-api#1792 and then include those tests here.

This should inherently resolve the following:

@shaneutt shaneutt changed the title Add conformance tests for UDPRoute Add conformance tests for UDPRoute & TCPRoute Jun 8, 2023
@shaneutt shaneutt self-assigned this Jun 8, 2023
@shaneutt shaneutt removed their assignment Jul 12, 2023
@shaneutt shaneutt self-assigned this Aug 23, 2023
@shaneutt shaneutt removed their assignment Aug 23, 2023
@shaneutt shaneutt added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 12, 2023
@shaneutt
Copy link
Member Author

Note that this is now blocked on https://github.com/kubernetes-sigs/blixt/milestone/8.

@cnvergence
Copy link

Recently I have added the initial UDPRoute test in kubernetes-sigs/gateway-api#2661.
I would like to continue the work on adding more scenarios and verifying the support on blixt as well.

@shaneutt
Copy link
Member Author

shaneutt commented Apr 2, 2024

Sounds good!

/assign @cnvergence

If you want to add the tests now, you can they will just need to be re-written once https://github.com/kubernetes-sigs/blixt/milestone/8 is complete. So if you prefer to wait until afterwards that is fine too.

@cnvergence
Copy link

awesome, thanks for the heads-up, I guess I can start with including this basic suite now

@shaneutt
Copy link
Member Author

shaneutt commented Apr 5, 2024

Sounds good!

We appreciate it, please reach out to us (here) if you need any support!

@shaneutt shaneutt removed the blocked label Apr 5, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 3, 2024
@shaneutt shaneutt added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 15, 2024
@cnvergence
Copy link

hi @shaneutt, sorry, I needed to drop off for the last few months.
I saw great progress in moving the controller to Rust.
Let me take a look this week by moving UDPRoute test here.

@shaneutt
Copy link
Member Author

No worries whatsoever! Thanks for pinging, if you need any support hit us up in #blixt on Kubernetes Slack! 🖖

@cnvergence
Copy link

I have ran into some issues, when running tests

blixt-controlplane-664b9f96f6-6nnxd manager 2024-08-29T10:01:45Z	INFO	Observed a panic in reconciler: runtime error: invalid memory address or nil pointer dereference	{"controller": "udproute", "controllerGroup": "gateway.networking.k8s.io", "controllerKind": "UDPRoute", "UDPRoute": {"name":"udp-coredns","namespace":"gateway-conformance-infra"}, "namespace": "gateway-conformance-infra", "name": "udp-coredns", "reconcileID": "0c314b36-5a47-41ff-b898-0f2483a3b829"}
blixt-controlplane-664b9f96f6-6nnxd manager panic: runtime error: invalid memory address or nil pointer dereference [recovered]
blixt-controlplane-664b9f96f6-6nnxd manager 	panic: runtime error: invalid memory address or nil pointer dereference
blixt-controlplane-664b9f96f6-6nnxd manager [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x17b971a]

I will continue to investigate the cause, then I will open the PR with the test from gw-api moved here.
I see gateway-api version is set to v0.8.1, would it be viable to update this as well?

@shaneutt
Copy link
Member Author

Yes, updating to the latest version would probably be good at this point as we've been lagging behind a bit 😅

@shaneutt
Copy link
Member Author

shaneutt commented Sep 5, 2024

Putting this on hold temporarily while we focus on v0.4.0, then right after that we should be able to get back to it.

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/tests blocked lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. on-hold priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
Status: Backlog
Development

No branches or pull requests

4 participants