-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply user-defined metadata (labels and annotations) when creating the release namespace #221
Comments
@dlipovetsky This is an interesting idea. You're correct in that currently, we just pass through the |
Thanks for triaging!
I hadn't considered passing through labels/annotations on the HelmChartProxy. I would recommend against it, mainly because it would effectively become part of the API, but lack discoverability, and versioning, among other things.
I think an API field would make sense. |
I'd like to hear from other users who need this; are they happy with one or more of the alternatives I listed above? Do they have other alternatives? I wouldn't want CAAPH to expand its API without a clear need. |
That makes sense, it would be a clever workaround but perhaps a bit too clever to be easily discovered by users.
I haven't heard of anyone else who has this use case. Maybe worth bringing it up in Slack or CAPI office hours? |
we're currently going with 2, a separate chart that creates namespaces along with their metadata. I think this is somehow a bootstrapping issue (you can't lift yourself pulling your shoes) and I'm also confused by the somewhat contrasting informations I've found on my path from helm/helm#3503 to here. I'm no Helm expert, but I can't figure out why I can create a ns simply adding an option to helm install, while I can't remove one with helm uninstall --remove-namespace. There must be reasons for this I ignore, here comes my asymmetry feeling. |
User Story
As a user, I would like to add metadata to the release namespace, as required by some charts [1]. A helm chart does not add metadata to the release namespace, for the same reason it does not create the release namespace.
Detailed Description
When CAAPH creates the release namespace, it should apply user-defined metadata (labels and annotations) to the namespace.
Anything else you would like to add:
Alternatives
AfterControlPlaneInitialized
lifecycle hook.Implementation
CAAPH delegates namespace creation to the helm client. This client does not add metadata to the namespace, and helm maintainers have made it clear that this will not change. To be able to add metadata to the namespace, CAAPH would have to implement its own namespace creation.
/kind feature
The text was updated successfully, but these errors were encountered: