🐛 Delete provider's CRDs and namespace along with the provider custom resource #169
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
Fedosin
changed the title
Now we keep provider's namespace and CRDs after we delete the provider, which polutes the system. System administrators have to manually delete stalled objects after that. After this PR operator will delete all providers components completely.
|
The initial idea was to have an identical behavior as |
|
Maybe it makes sense to split this PR in two parts: one related to CRDs and namespaces, and another to all other cluster-scoped resources. For instance, now we don't delete clusterroles and clusterrolebinding, which is clearly a bug. But ideally, we need to discuss the process of provider deletion in detail. Now namespaced resources are deleted because they have an owner reference to the provider object, and some cluster scoped resources are removed with clusterctl's delete. I think it's inconsistent and should be improved. |
Agree. Thinking of a use case we can of course delete everything in the most common use case we have, which is single-tenant management clusters. However I think it might be destructive in multi-tenant scenario, because then we would delete both instance specific and shared CRDs/web-hook components. |
|
/hold We decided to split this PR in two parts - one that fixes the bug with undeleted resources, and another that allows to regulate whether namespace and CRDs should be deleted or not. |
k8s-ci-robot
added
the
do-not-merge/hold
|
Close it for now... |
What this PR does / why we need it:
Now we keep provider's namespace and CRDs after we delete the provider, which pollutes the system. System administrators have to manually delete stalled objects after that. After this PR operator will delete all providers components completely.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #120