From df089ef9f628db4b64c03488f38e4e3375871ef8 Mon Sep 17 00:00:00 2001 From: nueavv Date: Thu, 13 Jun 2024 13:14:51 +0900 Subject: [PATCH] fix(nodegroup): add nil pointer check for nodegroup version Added a check to ensure that the nodegroup version is not nil before dereferencing it. This prevents potential runtime panics due to nil pointer dereference. Signed-off-by: nueavv --- pkg/cloud/services/eks/nodegroup.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkg/cloud/services/eks/nodegroup.go b/pkg/cloud/services/eks/nodegroup.go index 763d14b494..23200bf7e3 100644 --- a/pkg/cloud/services/eks/nodegroup.go +++ b/pkg/cloud/services/eks/nodegroup.go @@ -333,6 +333,11 @@ func (s *NodegroupService) reconcileNodegroupVersion(ng *eks.Nodegroup) error { return fmt.Errorf("parsing EKS version from spec: %w", err) } } + + // Check for nil pointers before dereferencing + if ng.Version == nil { + return fmt.Errorf("nodegroup version is nil") + } ngVersion := version.MustParseGeneric(*ng.Version) specAMI := s.scope.ManagedMachinePool.Spec.AMIVersion ngAMI := *ng.ReleaseVersion