-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasks for adopting CAPI's Server Side Apply #3530
Labels
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
Comments
PoCWhile waiting for controller-tools and listMapKey issues to be worked on, did an Initial PoC with test purpose CRDs. This required some hacks so the result needs to be confirmed when all the tasks listed in Hacks
// +optional
// +listType=map
// +listMapKey=id
Subnets []SubnetSpec `json:"subnets,omitempty"`
Scenario: BYO Infra CaseAWSClusterTemplate in ClusterClass apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: AWSClusterTemplate
metadata:
name: um-ec2-clusterclass-v1
spec:
template:
spec:
network:
vpc:
id: vpc-0e38e0a4712b9b316
subnets:
- id: subnet-0588d98dd78abf69b
availabilityZone: us-west-1c
isPublic: true
- id: subnet-0454fcf4f534539df
availabilityZone: us-west-1c
region: REPLACEME
sshKeyName: REPLACEME Findings
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: AWSCluster
metadata:
...
managedFields:
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
fieldsType: FieldsV1
fieldsV1:
f:metadata:
f:annotations:
f:cluster.x-k8s.io/cloned-from-groupkind: {}
f:cluster.x-k8s.io/cloned-from-name: {}
f:labels:
f:cluster.x-k8s.io/cluster-name: {}
f:topology.cluster.x-k8s.io/owned: {}
f:spec:
f:bastion:
f:allowedCIDRBlocks: {}
f:enabled: {}
f:controlPlaneLoadBalancer:
f:crossZoneLoadBalancing: {}
f:scheme: {}
f:identityRef:
f:kind: {}
f:name: {}
f:network:
f:cni:
f:cniIngressRules: {}
f:subnets: ⬅️
k:{"id":"subnet-0454fcf4f534539df"}:
.: {}
f:availabilityZone: {}
f:id: {}
f:isPublic: {}
k:{"id":"subnet-0588d98dd78abf69b"}:
.: {}
f:availabilityZone: {}
f:id: {}
f:isPublic: {}
f:vpc:
f:availabilityZoneSelection: {}
f:availabilityZoneUsageLimit: {}
f:id: {}
f:region: {}
f:sshKeyName: {}
manager: capi-topology ⬅️
operation: Apply
time: "2022-06-15T12:54:06Z"
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
fieldsType: FieldsV1
fieldsV1:
f:metadata:
f:finalizers:
.: {}
v:"awscluster.infrastructure.cluster.x-k8s.io": {}
f:spec:
f:controlPlaneEndpoint:
f:host: {}
f:port: {}
f:network:
f:subnets: ⬅️
k:{"id":"subnet-0454fcf4f534539df"}:
f:cidrBlock: {}
f:routeTableId: {}
f:tags:
.: {}
f:Name: {}
f:kubernetes.io/cluster/um-ec2-cc-cluster: {}
f:kubernetes.io/cluster/um-ec2-cluster: {}
f:kubernetes.io/role/internal-elb: {}
k:{"id":"subnet-0588d98dd78abf69b"}:
f:cidrBlock: {}
f:natGatewayId: {}
f:routeTableId: {}
f:tags:
.: {}
f:Name: {}
f:kubernetes.io/cluster/um-ec2-cc-cluster: {}
f:kubernetes.io/cluster/um-ec2-cluster: {}
f:kubernetes.io/role/elb: {}
f:vpc:
f:cidrBlock: {}
f:tags:
.: {}
f:Name: {}
manager: cluster-api-provider-aws-controller ⬅️
operation: Update
time: "2022-06-15T12:55:43Z"
... |
/triage accepted |
OCI provider fix for the problem: oracle/cluster-api-provider-oci#116 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
This issue is tracking the list of tasks to make CAPI's SSA (Server Side Apply) to work with CAPA.
Why do we need this?
CAPA's
spec.network.subnets
is coauthored by CAPI and CAPA controllers when using ClusterClass. To properly manage these coauthoring slices and prevent them continuously getting patched by both controllers, CAPI is now using Server-Side Apply.Changes Required in CAPA
The following issues require v1beta2 API version bump as a pre-requiste.
Other Issues to Follow
CAPA issues that will be resolved
The text was updated successfully, but these errors were encountered: