Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1alpha2] Implement AWSCluster controller #933

Closed
6 tasks done
vincepri opened this issue Jul 26, 2019 · 3 comments · Fixed by #942
Closed
6 tasks done

[v1alpha2] Implement AWSCluster controller #933

vincepri opened this issue Jul 26, 2019 · 3 comments · Fixed by #942
Assignees
@ncdc
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v0.4.0 (v1alpha2)

Comments

@vincepri
Copy link
Member

vincepri commented Jul 26, 2019 •
edited by ncdc
Loading

/kind feature

Describe the solution you'd like

  • Update Cluster API module dependency to the latest master release.
  • Scaffold a new controller and type with kubebuilder using kubebuilder create api --version v1alpha2 --group infrastructure --resource=true --controller=true --kind AWSCluster --make=false.
  • Migrate AWSClusterProviderSpec fields to the newly created AWSClusterSpec.
  • Migrate AWSClusterProviderStatus fields to the newly created AWSClusterStatus.
  • Add Status.Ready boolean field to comply with Cluster API expectations.
  • Migrate Actuator and v1alpha1 Cluster API controller logic to AWSCluster controller.
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 26, 2019
@vincepri vincepri added this to the v0.4 milestone Jul 26, 2019
@vincepri vincepri added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jul 26, 2019
@texascloud texascloud mentioned this issue Jul 29, 2019
Closed
@ncdc
Copy link
Contributor

ncdc commented Jul 30, 2019

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jul 30, 2019
@ncdc ncdc mentioned this issue Aug 1, 2019
Merged
@ncdc
Copy link
Contributor

ncdc commented Aug 1, 2019

Fixed by #942
/close

@k8s-ci-robot
Copy link
Contributor

@ncdc: Closing this issue.

In response to this:

Fixed by #942
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ncdc ncdc

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v0.4.0 (v1alpha2)
Development

Successfully merging a pull request may close this issue.

Add AWSCluster ncdc/cluster-api-provider-aws
3 participants
@ncdc @vincepri @k8s-ci-robot