Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable metrics-scraping #1222

Closed
bavarianbidi opened this issue Mar 9, 2021 · 1 comment · Fixed by #1320
Closed

Enable metrics-scraping #1222

bavarianbidi opened this issue Mar 9, 2021 · 1 comment · Fixed by #1320
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@bavarianbidi
Copy link
Contributor

bavarianbidi commented Mar 9, 2021

/kind feature

Describe the solution you'd like
I created PR 📖 document metrics scraping and enable metrics services via annotations at CAPI and also some PRs on other infraproviders to document how to setup all the RBAC stuff together with kube-rbac-proxy and prometheus to scrape metrics from CAPI containers.

The annotation already exist at capz but was removed last year with this commit in PR #1019 by @devigned

Using the prometheus-operator is definitely a valid solution to bring some observability in a cluster, but imho using a "simple" prometheus deployment/statefulset with a very common config is also very proven in a k8s environment.

would you accept a PR, where i set some annotations on the metrics-service?

metadata:
  annotations:
    prometheus.io/scrape: "true"
    prometheus.io/port: "8443"
    prometheus.io/scheme: "https"
@CecileRobertMichon
Copy link
Contributor

would you accept a PR, where i set some annotations on the metrics-service?

@bavarianbidi, yes please go ahead and open a PR to add it back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants