Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occasional flake stopping manager in apivalidations envtest #2029

Open
mdbooth opened this issue Apr 18, 2024 · 5 comments
Open

Occasional flake stopping manager in apivalidations envtest #2029

mdbooth opened this issue Apr 18, 2024 · 5 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mdbooth
Copy link
Contributor

mdbooth commented Apr 18, 2024

/kind bug

An example:
https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-openstack/2012/pull-cluster-api-provider-openstack-test/1780643147475324928/build-log.txt

  �[1mSTEP:�[0m Tearing down manager �[38;5;243m@ 04/17/24 17:20:20.381�[0m
  "level"=0 "msg"="Stopping and waiting for non leader election runnables"
  "level"=0 "msg"="Stopping and waiting for leader election runnables"
  "level"=0 "msg"="Stopping and waiting for caches"
  "level"=0 "msg"="Stopping and waiting for webhooks"
  �[38;5;9m[FAILED]�[0m in [DeferCleanup (Suite)] - /home/prow/go/src/sigs.k8s.io/cluster-api-provider-openstack/test/e2e/suites/apivalidations/suite_test.go:152 �[38;5;243m@ 04/17/24 17:20:25.384�[0m
  �[38;5;243m<< Timeline�[0m

  �[38;5;9m[FAILED] Timed out after 5.002s.
  Manager should stop
  Expected
      <chan struct {} | len:0, cap:0>: 0xc0008554a0
  to be closed�[0m
  �[38;5;9mIn �[1m[DeferCleanup (Suite)]�[0m�[38;5;9m at: �[1m/home/prow/go/src/sigs.k8s.io/cluster-api-provider-openstack/test/e2e/suites/apivalidations/suite_test.go:152�[0m �[38;5;243m@ 04/17/24 17:20:25.384�[0m
�[38;5;243m------------------------------�[0m

The default timeout is 1 second. I bumped it to 5, but it seems that is not enough. I doubt this is an actual code problem, but I wouldn't 100% rule it out.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 18, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 18, 2024

@JoelSpeed I think this is in code I copied from you. I don't suppose you've seen this tearing down envtests, have you?

@JoelSpeed
Copy link

Have never seen issues with tearing down envtest before no, this is new to me

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 17, 2024
@EmilienM
Copy link
Contributor

@mdbooth still seeing it? not myself recently

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
Status: Inbox
Development

No branches or pull requests

5 participants