🐛 Wait and requeue if LB + its ports not deleted #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
EmilienM
changed the title
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/test pull-cluster-api-provider-openstack-e2e-test |
|
/lgtm |
k8s-ci-robot
added
lgtm
mdbooth
reviewed
Jun 12, 2024
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
added
size/M
EmilienM
changed the title
If the LB that is being deleted when a cluster is deleted, it'll go through the PENDING_DELETE state and at this stage there is nothing we can do but wait for the LB to be actually deleted. If the LB is in that state during the deletion, let's just return no error but request a reconcile after some time.
k8s-ci-robot
added
size/L
EmilienM
changed the title
EmilienM
changed the title
In a best-effort mode, when cleaning a load-balancer, wait for the ports with a device ID (mapped with the LB ID) and a certain prefix is deleted (by Octavia itself, not CAPO managed) before claiming the LB is really deleted. This will avoid the reconcile to fail later when trying to remove the network while some ports are still attached.
EmilienM
commented
Jun 13, 2024
| } | ||
|
|
||
| if lb == nil { | ||
| return nil | ||
| if lbPortsExist { | ||
| s.scope.Logger().Info("Load balancer ports still exist, waiting for them to be deleted", "name", loadBalancerName) |
|
@mdbooth ready for review when time permits. Maybe over-engineered but it does the job apparently. Feedback is open. |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Wait and requeue if LB is in PENDING_DELETE
If the LB that is being deleted when a cluster is deleted, it'll go
through the PENDING_DELETE state and at this stage there is nothing we
can do but wait for the LB to be actually deleted.
If the LB is in that state during the deletion, let's just return no
error but request a reconcile after some time.
Wait for Octavia-managed ports to be removed
In a best-effort mode, when cleaning a load-balancer, wait for the ports
with a device ID (mapped with the LB ID) and a certain prefix is deleted
(by Octavia itself, not CAPO managed) before claiming the LB is really
deleted.
This will avoid the reconcile to fail later when trying to remove the
network while some ports are still attached.
Which issue(s) this PR fixes:
Fixes #2124
Fixes #2121