Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStackIdentityReference in v1beta is missing minimum length validations on its fields #2137

Open
mdbooth opened this issue Jul 4, 2024 · 0 comments
Open

OpenStackIdentityReference in v1beta is missing minimum length validations on its fields #2137

mdbooth opened this issue Jul 4, 2024 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mdbooth
Copy link
Contributor

mdbooth commented Jul 4, 2024

/kind bug

v1alpha6 and v1alpha7 both have Minlength=1 on Kind and Name, e.g.:

cluster-api-provider-openstack/api/v1alpha7/identity_types.go

Line 21 in ffe572e

type OpenStackIdentityReference struct {

While v1beta1 has Required, it does not have a Minlength, so empty values are permitted:

cluster-api-provider-openstack/api/v1beta1/identity_types.go

Line 21 in ffe572e

type OpenStackIdentityReference struct {

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
CAPO Roadmap
Status: Inbox
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdbooth @k8s-ci-robot