Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeting Array of Reserved Servers #255

Closed
dsieczko opened this issue May 24, 2021 · 5 comments · Fixed by #287
Closed

Targeting Array of Reserved Servers #255

dsieczko opened this issue May 24, 2021 · 5 comments · Fixed by #287
Assignees

Comments

@dsieczko
Copy link

dsieczko commented May 24, 2021

User has reserved servers of both a stock configuration and a stock configuration that's been customized, in this case an m3.large.x86.

In order to avoid having a machine provision into an incorrect node pool, a user needs to pass a list of reservation ids, and not use next-available. Line 51 in packetmachine_types.go..

Currently, Cluster API only supports a string, single reservation ID or next-available. This would need to be updated to support lists.

This behavior can also help distribute reserved servers deliberately across a data center to better support things like BGP ECMP load balancing.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 22, 2021
@detiber
Copy link
Member

detiber commented Aug 26, 2021

/remove-lifecycle stale
/assign

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 26, 2021
@detiber
Copy link
Member

detiber commented Aug 26, 2021

Taking a look at this now, I'm thinking of just adding support for comma separated reservation ids for now to the existing field for now to avoid changing up the API at this point, but will likely look to clean up the API down the line (possibly along with the larger rebranding effort for the provider).

@jhead-slg
Copy link
Contributor

Would be great to get the comma separated support if the v1alpha4 release is still a ways off.

@detiber
Copy link
Member

detiber commented Sep 23, 2021

I've created a PR for backporting the changes to v0.3.x, and am currently working on some initial validation of the changes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants