Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing the support for older packet-ccm cloud provider #681

Closed
displague opened this issue Dec 7, 2023 · 3 comments
Closed

removing the support for older packet-ccm cloud provider #681

displague opened this issue Dec 7, 2023 · 3 comments

Comments

@displague
Copy link
Member

Consider removing the support for older packet-ccm cloud provider entirely, only supporting cloud-provider-equinix-metal (equinixmetal prefix). The method of introspection we used to figure out which cloud provider folks had installed:

  • Doesn't work with the newer controller runtime code
  • Is a bit of a hack where we had to swallow client errors to get it to work
  • Would require a lot of weird refactoring and eating of wrapped errors to work now
  • Doesn't seem needed at this point as who is even using the older packet-ccm at this point?
  • Is not how upstream docker handles it (they just set providerid prefix to docker:////) or another provider like azure handles it (they just straight up go with the UUID and no prefix, it seems).

Originally posted by @cprivitere in #674 (comment)

@displague
Copy link
Member Author

Covered in:

@displague
Copy link
Member Author

Removal of the packet-ccm means that we can assert there is only one supported CCM type and we will no longer need to detect which may be running.

The commits above indicated through semantic commit tags that this is a breaking change, as such it will be called out in the release notes.

@displague
Copy link
Member Author

Closed by #691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant