From 65fc98c1f5ac32681eb481b820e3f520e0720149 Mon Sep 17 00:00:00 2001 From: Cameron McAvoy Date: Wed, 13 Sep 2023 12:31:22 -0500 Subject: [PATCH] Fix excessive trace logging in the machine health check controller --- .../machinehealthcheck/machinehealthcheck_targets.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/controllers/machinehealthcheck/machinehealthcheck_targets.go b/internal/controllers/machinehealthcheck/machinehealthcheck_targets.go index 5d174fb63155..c9db29b511fc 100644 --- a/internal/controllers/machinehealthcheck/machinehealthcheck_targets.go +++ b/internal/controllers/machinehealthcheck/machinehealthcheck_targets.go @@ -280,13 +280,13 @@ func (r *Reconciler) getNodeFromMachine(ctx context.Context, clusterClient clien // healthCheckTargets health checks a slice of targets // and gives a data to measure the average health. -func (r *Reconciler) healthCheckTargets(targets []healthCheckTarget, logger logr.Logger, timeoutForMachineToHaveNode metav1.Duration) ([]healthCheckTarget, []healthCheckTarget, []time.Duration) { +func (r *Reconciler) healthCheckTargets(targets []healthCheckTarget, l logr.Logger, timeoutForMachineToHaveNode metav1.Duration) ([]healthCheckTarget, []healthCheckTarget, []time.Duration) { var nextCheckTimes []time.Duration var unhealthy []healthCheckTarget var healthy []healthCheckTarget for _, t := range targets { - logger = logger.WithValues("Target", t.string()) + logger := l.WithValues("Target", t.string()) logger.V(3).Info("Health checking target") needsRemediation, nextCheck := t.needsRemediation(logger, timeoutForMachineToHaveNode)