From ab78f3fd4d7a127c94711716fe672bb31938a3da Mon Sep 17 00:00:00 2001
From: huangwei <wei.huang@smartx.com>
Date: Mon, 13 May 2024 12:06:45 +0800
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Skip=20publishing=20the=20Remedi?=
 =?UTF-8?q?ationRestricted=20event=20when=20there=20are=20no=20unhealty=20?=
 =?UTF-8?q?target?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../machinehealthcheck_controller.go              | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/internal/controllers/machinehealthcheck/machinehealthcheck_controller.go b/internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
index f485b7e5c0b0..6bbb327d9afb 100644
--- a/internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
+++ b/internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
@@ -280,12 +280,15 @@ func (r *Reconciler) reconcile(ctx context.Context, logger logr.Logger, cluster
 			Message:  message,
 		})
 
-		r.recorder.Event(
-			m,
-			corev1.EventTypeWarning,
-			EventRemediationRestricted,
-			message,
-		)
+		// If there are no unhealthy target, skip publishing the `RemediationRestricted` event to avoid misleading.
+		if len(unhealthy) != 0 {
+			r.recorder.Event(
+				m,
+				corev1.EventTypeWarning,
+				EventRemediationRestricted,
+				message,
+			)
+		}
 		errList := []error{}
 		for _, t := range append(healthy, unhealthy...) {
 			if err := t.patchHelper.Patch(ctx, t.Machine); err != nil {