Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Kubetest parameters #10171

Closed
fabriziopandini opened this issue Feb 19, 2024 · 3 comments · Fixed by #10172
Closed

Check Kubetest parameters #10171

fabriziopandini opened this issue Feb 19, 2024 · 3 comments · Fixed by #10172
Assignees
Labels
area/ci Issues or PRs related to ci kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fabriziopandini
Copy link
Member

What steps did you take and what happened?

I was checking a test running conformance on #10166 and I noticed those logs entries

  You're using deprecated Ginkgo functionality:
  =============================================
    --ginkgo.flakeAttempts is deprecated, use --ginkgo.flake-attempts instead
    Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#changed-command-line-flags
    --ginkgo.progress is deprecated .  The functionality provided by --progress was confusing and is no longer needed.  Use --show-node-events instead to see node entry and exit events included in the timeline of failed and verbose specs.  Or you can run with -vv to always see all node events.  Lastly, --poll-progress-after and the PollProgressAfter decorator now provide a better mechanism for debugging specs that tend to get stuck.
    --ginkgo.slowSpecThreshold is deprecated use --slow-spec-threshold instead and pass in a duration string (e.g. '5s', not '5.0')
    Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#changed--slowspecthreshold

It would be great to check if we have the same issue on the more recent branches (main, 1.6., 1.%) and eventually fix it

cc @kubernetes-sigs/cluster-api-release-team

What did you expect to happen?

Our tests to not use deprecated flags

Cluster API version

1.4.x

Kubernetes version

No response

Anything else you would like to add?

No response

Label(s) to be applied

/kind bug
/area ci

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/ci Issues or PRs related to ci needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 19, 2024
@fabriziopandini
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 19, 2024
@adilGhaffarDev
Copy link
Contributor

We see these deprecation warnings in main, 1.6, and 1.5 too. I will open a PR with the fix. /assign

@adilGhaffarDev
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to ci kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants