Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machine should not stay in running phase after the infra obj been deleted #1398

Closed
xrmzju opened this issue Sep 8, 2019 · 6 comments · Fixed by #1458
Closed

machine should not stay in running phase after the infra obj been deleted #1398

xrmzju opened this issue Sep 8, 2019 · 6 comments · Fixed by #1458
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@xrmzju
Copy link
Member

xrmzju commented Sep 8, 2019

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
after machine turns into running phase, i delete the infra object and machine controller watches the event but only logs about the infra obj not found err, and stays in running phase

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api version:
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 8, 2019
@ncdc ncdc added this to the v0.2.x milestone Sep 11, 2019
@ncdc ncdc added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 11, 2019
@kashifest
Copy link
Contributor

I want to take this task if no one else is looking into it

@kashifest
Copy link
Contributor

/assign @kashifest

@kashifest
Copy link
Contributor

What is the expectation here?

@ncdc
Copy link
Contributor

ncdc commented Sep 26, 2019

If Machine.Status.InfrastructureReady is true and we get a 404 not found back from the call to r.reconcileExternal from within reconcileInfrastructure, we probably need to set Machine.Status.ErrorReason and ErrorMessage. WDYT @vincepri?

@vincepri
Copy link
Member

That's what I would expect as well

@timothysc timothysc added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 26, 2019
@kashifest
Copy link
Contributor

Ok Thanks for the information. I am working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
6 participants