Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubeadm control plane] health checks #2243

Closed
chuckha opened this issue Jan 31, 2020 · 3 comments · Fixed by #2319
Closed

[kubeadm control plane] health checks #2243

chuckha opened this issue Jan 31, 2020 · 3 comments · Fixed by #2319
Assignees
@chuckha @randomvariable
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.3.0

Comments

@chuckha
Copy link
Contributor

chuckha commented Jan 31, 2020

User Story
In order to support cluster operations (scale up, scale down, upgrade), the controller must know if the cluster is in a state to run the operations. To this end we need a health check library for those features to use.

Detailed Description

Please see the health checks in issue #2241.

This requires a central library that will connect to a single etcd instance

  1. A way to talk to a specific etcd client

This library can be used and a health check client can be built on top of it. This work will be coordinated with #2241 and #2242

/kind feature
/assign
/lifecycle active
/milestone v0.3.0
/priority important-soon
@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jan 31, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Jan 31, 2020
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jan 31, 2020
@chuckha
Copy link
Contributor Author

chuckha commented Jan 31, 2020

/assign @randomvariable

Also assigning naadir since he did the bulk of the thinking on this one 🙏

This was referenced Jan 31, 2020
Closed
Merged
@dlipovetsky dlipovetsky mentioned this issue Feb 5, 2020
Closed
This was referenced Feb 8, 2020
Merged
Merged
@vincepri
Copy link
Member

@chuckha Should this be part of the v0.3.0-rc.0 milestone or do you want to take more time to complete it?

@vincepri vincepri mentioned this issue Feb 12, 2020
Closed
@chuckha
Copy link
Contributor Author

chuckha commented Feb 12, 2020

@vincepri i'll have the PR open today!

@chuckha chuckha mentioned this issue Feb 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuckha chuckha

@randomvariable randomvariable

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

✨ Adds control plane healthcheck for workload clusters chuckha/cluster-api
4 participants
@chuckha @randomvariable @vincepri @k8s-ci-robot