Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e framework] Kubeadm Control Plane test makes bad assumptions #2291

Closed
chuckha opened this issue Feb 8, 2020 · 1 comment · Fixed by #2294
Closed

[e2e framework] Kubeadm Control Plane test makes bad assumptions #2291

chuckha opened this issue Feb 8, 2020 · 1 comment · Fixed by #2294
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone
v0.3.0

Comments

@chuckha
Copy link
Contributor

chuckha commented Feb 8, 2020

The e2e framework makes the assumption that a control plane provider will create all machines very quickly and then waits x for them all to be running. This works great if machines get created very quickly, but with the changes coming in #2016 (even if this particular pr doesn't merge, these changes are coming), we need to wait for the control plane to come up instead of assuming the machines come up immediately and then waiting for it to run

/kind bug
/lifecycle active
@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. kind/bug Categorizes issue or PR as related to a bug. labels Feb 8, 2020
@chuckha
Copy link
Contributor Author

chuckha commented Feb 8, 2020

/milestone v0.3.0

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Feb 8, 2020
@chuckha chuckha mentioned this issue Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

🏃 Refactor of the e2e framework chuckha/cluster-api
2 participants
@chuckha @k8s-ci-robot