Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watching node in remote clusters should use a cache #2412

Closed
JoelSpeed opened this issue Feb 24, 2020 · 1 comment · Fixed by #2496
Closed

Watching node in remote clusters should use a cache #2412

JoelSpeed opened this issue Feb 24, 2020 · 1 comment · Fixed by #2496
Assignees
Milestone

Comments

@JoelSpeed
Copy link
Contributor

Note: this is only applicable once #2250 is merged

Watching of nodes in remote clusters was introduced as part of the Machine Health Checking work in #2250.

Currently it uses individual node informers from client-go to subscribe to events for nodes within the remote clusters, however, it could use the newly merged controller-runtime source type for kindWithCache which is designed for this purpose (kubernetes-sigs/controller-runtime#794) which would make the implementation more controller-runtime native and a bit simpler too.

Once kubernetes-sigs/controller-runtime#794 is available in a release, the dependency on controller-runtime should be updated and this should be implemented

/assign @JoelSpeed

@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Feb 24, 2020

I've already had a go at this, which I can add as a WIP PR once #2250 is merged.

I need to test it on a real cluster though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants