Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle kubeadm 1.24 kubelet ConfigMap name change #5921

Closed
Tracked by #5968
sbueringer opened this issue Jan 10, 2022 · 3 comments · Fixed by #6176
Closed
Tracked by #5968

Handle kubeadm 1.24 kubelet ConfigMap name change #5921

sbueringer opened this issue Jan 10, 2022 · 3 comments · Fixed by #6176
Assignees
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@sbueringer
Copy link
Member

sbueringer commented Jan 10, 2022

With kubeadm 1.24 the UnversionedKubeletConfigMap feature gate is moving to beta and thus is enabled per default.

According to upcoming notable changes in kubeadm 1.24, "kubeadm upgrade" will automatically handle this. As we're not running kubeadm upgrade during upgrade I suspect we have to implement something on our side.

/kind feature
/area control-plane

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/control-plane Issues or PRs related to control-plane lifecycle management labels Jan 10, 2022
@sbueringer
Copy link
Member Author

sbueringer commented Jan 10, 2022

@neolit123 If you have some time, would be great to hear what you think about it.

@fabriziopandini
Copy link
Member

On top of my mind in KCP we have specific logic for

  1. creating new versioned KubeletConfigMap before upgrade
  2. editing new versioned if required (e.g for adapting the cgroup default driver change happened in kubeadm few version ago)

I think that 1 should stop happening starting from 1.24, but a deeper analysis is required.

/milestone v1.1
It will be nice to get into the release + backport if the change is simple

@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Jan 11, 2022
@fabriziopandini fabriziopandini modified the milestones: v1.1, v1.2 Feb 3, 2022
@ykakarap
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants