Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify UX in clusterctl upgrades #7319

Closed
fabriziopandini opened this issue Sep 30, 2022 · 2 comments · Fixed by #7376
Closed

Simplify UX in clusterctl upgrades #7319

fabriziopandini opened this issue Sep 30, 2022 · 2 comments · Fixed by #7376
Assignees
Labels
area/clusterctl Issues or PRs related to clusterctl kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fabriziopandini
Copy link
Member

clusterctl dropped support for many instances of the same providers a couple of release ago, but there is still some part of the code that consider this uses case. By cleaning them up we can simplify the UX of some commands.

One of them is clusterctl upgrade apply UX, that when upgrading single providers by using flags like --bootstrap, --infrastructure, etc requires the user to specify namespace/name:version. this can be simplified by allowing users to specify only name:version and automatically discover the namespace behind the scene.

This requires:

  • Change the parseUpgradeItem implementing the auto-discovery mechanism; please note that we should support both formats for a certain time, giving notice that the old format is deprecated
  • Fix unit tests accordingly
  • Do some manual validation (upgrading a single provider is not covered by existing E2E tests)
  • Change in parameters description/documentation

/area clusterctl
/kind cleanup

@k8s-ci-robot k8s-ci-robot added area/clusterctl Issues or PRs related to clusterctl kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 30, 2022
@sbueringer
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 30, 2022
@oscr
Copy link
Contributor

oscr commented Oct 8, 2022

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants