Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Response metric to Runtime SDK hook client #7952

Closed
MaxFedotov opened this issue Jan 19, 2023 · 3 comments · Fixed by #7956
Closed

Add Response metric to Runtime SDK hook client #7952

MaxFedotov opened this issue Jan 19, 2023 · 3 comments · Fixed by #7956
Assignees
@MaxFedotov
Labels
area/clusterclass Issues or PRs related to clusterclass kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@MaxFedotov
Copy link
Contributor

User Story

As a user/operator I would like to have an additional response metric for Runtime SDK extensions to be able to trigger alerts in case of ResponseStatusFailure response.

Detailed Description

CAPI added metrics for Runtime SDK in Add metrics to Runtime SDK hook client. But the existing metric capi_runtime_sdk_requests_total covers only HTTP status of the request. So if the request completes, but returns a ResponseStatusFailure response it is impossible to monitor\trigger the alert.

/kind feature
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 19, 2023
@k8s-ci-robot
Copy link
Contributor

@MaxFedotov: This issue is currently awaiting triage.

If CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

Sounds good to me!
Thx for opening the issue

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jan 19, 2023
@sbueringer sbueringer added area/topology and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 19, 2023
@MaxFedotov
Copy link
Contributor Author

/assign

@MaxFedotov MaxFedotov mentioned this issue Jan 19, 2023
Merged
@killianmuldoon killianmuldoon added the area/clusterclass Issues or PRs related to clusterclass label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxFedotov MaxFedotov

Labels
area/clusterclass Issues or PRs related to clusterclass kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ add response metrics for RuntimeSDK hook client MaxFedotov/cluster-api
4 participants
@sbueringer @MaxFedotov @k8s-ci-robot @killianmuldoon