Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MachineSet.spec.replicas defaulting should take into account autoscaler min/max size if defined #8085

Closed
sbueringer opened this issue Feb 8, 2023 · 5 comments · Fixed by #9649
Closed

MachineSet.spec.replicas defaulting should take into account autoscaler min/max size if defined #8085

sbueringer opened this issue Feb 8, 2023 · 5 comments · Fixed by #9649
Assignees
@aiden-von
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sbueringer
Copy link
Member

sbueringer commented Feb 8, 2023 •
edited
Loading

This is a follow-up issue to #7293.

The implementation for MachineDeployment has been merged in #7990

The goal of this issue is to do ~ the same for MachineSets (xref: #7293 (comment))

/kind feature
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 8, 2023
@sbueringer
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 8, 2023
@sbueringer
Copy link
Member Author

cc @elmiko

@aiden-von
Copy link
Contributor

aiden-von commented Oct 29, 2023 •
edited
Loading

Hello @sbueringer, May I handle this issue?
I understood that the MachineSet replica default policy should be applied in the same way as the MachineDeployment replica default policy considering the autoscaler.
It doesn't seem difficult to contribute for the first time, is it okay?

@sbueringer
Copy link
Member Author

Yup, should be a good one :)

Feel free to go ahead and assign yourself the issue

@aiden-von
Copy link
Contributor

/assign aiden-von

@aiden-von aiden-von mentioned this issue Oct 31, 2023
Merged
@okozachenko1203 okozachenko1203 mentioned this issue Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aiden-von aiden-von

Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 MS: improve replica defaulting for autoscaler aiden-von/cluster-api
3 participants
@sbueringer @k8s-ci-robot @aiden-von