Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhook warning for Clusters without updated ClusterClass #8496

Closed
killianmuldoon opened this issue Apr 6, 2023 · 4 comments · Fixed by #8746
Closed

Add webhook warning for Clusters without updated ClusterClass #8496

killianmuldoon opened this issue Apr 6, 2023 · 4 comments · Fixed by #8746
Assignees
@killianmuldoon
Labels
area/runtime-sdk Issues or PRs related to Runtime SDK triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@killianmuldoon
Copy link
Contributor

As part of #7985 Topology-managed cluster validation was weakened to allow the creation of a Cluster even when a ClusterClass does not exist or has not been successfully reconciled.

Once webhook warnings are supported in controller runtime - tracking issue kubernetes-sigs/controller-runtime#1896 - CAPI should return a warning where a Cluster is not fully validated. This will allow clients to interpret the warning strictly if they choose.

/area runtime-sdk
@k8s-ci-robot k8s-ci-robot added area/runtime-sdk Issues or PRs related to Runtime SDK needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 6, 2023
@killianmuldoon
Copy link
Contributor Author

Alternatively we could include an annotation that implements strict validation - but I'd prefer to follow the webhook warnings pattern here.

@killianmuldoon killianmuldoon mentioned this issue Apr 6, 2023
Closed
34 tasks
@fabriziopandini
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 11, 2023
@sbueringer
Copy link
Member

Webhook warnings will be supported in the upcoming v0.15 CR release

@killianmuldoon
Copy link
Contributor Author

/assign

@killianmuldoon killianmuldoon mentioned this issue May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@killianmuldoon killianmuldoon

Labels
area/runtime-sdk Issues or PRs related to Runtime SDK triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Add webhook warning for missing ClusterClass killianmuldoon/cluster-api
4 participants
@sbueringer @fabriziopandini @k8s-ci-robot @killianmuldoon