Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return CLC conversion warnings to user using warnings of validation webhook #8944

Open
invidian opened this issue Jun 30, 2023 · 4 comments
Open

Return CLC conversion warnings to user using warnings of validation webhook #8944

invidian opened this issue Jun 30, 2023 · 4 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@invidian
Copy link
Member

What would you like to be added (User Story)?

As a user I would like to be informed while creating a cluster using Ignition that my configuration has warnings.

Detailed Description

As a follow up to #4279, now that we have warnings support in validation webhooks, we should make CLC conversion code added in #4172 (comment) return warnings to the user.

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 30, 2023
@invidian invidian mentioned this issue Jun 30, 2023
Closed
@sbueringer
Copy link
Member

@invidian On which resources / webhooks would we implement the warnings?

@invidian
Copy link
Member Author

IIRC on KubeadmControlPlane and KubeadmConfigTemplate. Everything which has containerLinuxConfig field, so perhaps KubeadmConfig as well.

@killianmuldoon
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 3, 2023
@fabriziopandini
Copy link
Member

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Apr 11, 2024
@fabriziopandini fabriziopandini added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sbueringer @fabriziopandini @invidian @k8s-ci-robot @killianmuldoon