Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grammatically incorrect plurals in the release notes tool #9009

Closed
Tracked by #9008
nawazkh opened this issue Jul 18, 2023 · 2 comments · Fixed by #9024
Closed
Tracked by #9008

Fix grammatically incorrect plurals in the release notes tool #9009

nawazkh opened this issue Jul 18, 2023 · 2 comments · Fixed by #9024
Assignees
@Dhairya-Arora01
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@nawazkh
Copy link
Member

nawazkh commented Jul 18, 2023

What steps did you take and what happened?

Release notes tool logs incorrectly framed plurals in the release notes. Example: 1 new commits merged

What did you expect to happen?

It would be nice if the release notes tool outputs singular nouns when there is just one change and plural nouns when there are many.

Cluster API version

Unrelated to CAPI version.

Kubernetes version

Unrelate to K8s version

Anything else you would like to add?

This issue should be part of #9008

Label(s) to be applied

/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 18, 2023
@nawazkh nawazkh mentioned this issue Jul 18, 2023
Closed
@killianmuldoon
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 18, 2023
@Dhairya-Arora01
Copy link
Contributor

/assign

This was referenced Jul 21, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dhairya-Arora01 Dhairya-Arora01

Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
4 participants
@k8s-ci-robot @nawazkh @killianmuldoon @Dhairya-Arora01