Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make time to wait for blocked move configurable #9194

Open
nojnhuh opened this issue Aug 15, 2023 · 4 comments
Open

Make time to wait for blocked move configurable #9194

nojnhuh opened this issue Aug 15, 2023 · 4 comments
Assignees
@nojnhuh
Labels
area/clusterctl Issues or PRs related to clusterctl kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@nojnhuh
Copy link
Contributor

nojnhuh commented Aug 15, 2023 •
edited
Loading

What would you like to be added (User Story)?

As a user, I want to configure how long I wait in total for resources blocking a move before timing out.

Detailed Description

#8690 hardcodes an interval of time to wait for each resource during clusterctl move for resources not to have the clusterctl.cluster.x-k8s.io/block-move annotation. The interval should instead be configurable from the CLI and apply to the entire set of resources blocking move. #8690 (comment)

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
/area clusterctl
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/clusterctl Issues or PRs related to clusterctl needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 15, 2023
@nojnhuh nojnhuh mentioned this issue Aug 15, 2023
Merged
@fabriziopandini
Copy link
Member

/triage accepted

however, IMO we should have a timeout for the entire waitMove operation, not a timeout for waitMove for each object like we have today, because this could lead the users to way x times the value he/she/they are settings

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 17, 2023
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 17, 2023

Edited to clarify

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 18, 2023

/assign

@nojnhuh nojnhuh mentioned this issue Nov 21, 2023
Closed
@fabriziopandini
Copy link
Member

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nojnhuh nojnhuh

Labels
area/clusterctl Issues or PRs related to clusterctl kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Make timeout to wait for blocked move global and configurable nojnhuh/cluster-api
3 participants
@fabriziopandini @nojnhuh @k8s-ci-robot