Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure doc.crds.dev is updated on new release #9290

Closed
2 of 4 tasks
cahillsf opened this issue Aug 23, 2023 · 10 comments
Closed
2 of 4 tasks

Ensure doc.crds.dev is updated on new release #9290

cahillsf opened this issue Aug 23, 2023 · 10 comments
Assignees
Labels
area/release Issues or PRs related to releasing kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@cahillsf
Copy link
Member

cahillsf commented Aug 23, 2023

Part of Improvement tasks for v1.6 release cycle #9104

automate updates to specific versions of https://doc.crds.dev/github.com/kubernetes-sigs/cluster-api after release is cut
the link: https://doc.crds.dev/github.com/kubernetes-sigs/cluster-api@latest needs to be called at least once before it's cached as the base page for the repo. The idea is to automate that update - we could initially document checking that page as a task during the release process manually. Automation can also be considered, i.e the same way how it is done in https://github.com/oracle/cluster-api-provider-oci/blob/main/.github/workflows/release.yaml#L28-L31

There is discussion in the umbrella issue regarding whether automation is worth the maintenance effort. As a first step we will document that this link needs to be called after the release has been cut, and continue discussing tradeoffs for pursuing automation if needed.

  • document that the new release tag link needs to be accessed in order to index the updated tag
  • attempt to address the latest tag behavior when no tag is provided in the URL params

/kind documentation
/area release

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. area/release Issues or PRs related to releasing needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 23, 2023
@cahillsf
Copy link
Member Author

/assign cahillsf

@sbueringer
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 23, 2023
@cahillsf
Copy link
Member Author

as a related issue, we have this issue with the docs page:

I do not why, but when I click the above link, I have list of CRDs from v1.4.5, should we change it to point to latest?

I get the same, I have no idea

After further investigation, it appears that the default tag to be served if not provided in the URL params will be based on the time column of the tags in the database (src). Running a local instance of this app, I have evidence that the time is based off of the most recent push to the tag

For example v.1.5.0 in my local db: https://a.cl.ly/qGu6e4oY

Corresponds to the most recent push GH link: screenshot

This means that in order to consistently serve the true latest tag as the default we will either need to:

  • ensure that when backporting from main, the most recent tag is updated last - in this case v1.4.5 was updated more recently than v1.5.0
  • update the logic in select statement to sort by name rather than time

@sbueringer
Copy link
Member

I think ideally they should serve the latest release as latest (or the one with the highest semver)

@furkatgofurov7
Copy link
Member

  • ensure that when backporting from main, the most recent tag is updated last - in this case v1.4.5 was updated more recently than v1.5.0

Thanks for digging into this, and finding out a reasoning behind it.

I believe we can't always make sure backporting is done to the latest tag at last IMO, so ideally I would fall into the second option and try to update the logic in the crdsdev/doc repo itself

@furkatgofurov7
Copy link
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 23, 2023
@cahillsf
Copy link
Member Author

cahillsf commented Aug 24, 2023

I see you found this issue as well Stefan. Seems unlikely that opening an issue to address this behavior will get prioritized.

Also it looks like this option would not work anyway:

ensure that when backporting from main, the most recent tag is updated last - in this case v1.4.5 was updated more recently than v1.5.0

It seems that once the tag has been initially indexed, the time will not be updated as it will only reindex tags it has not seen before (src).

I can take a shot at opening a PR to sort by semver tag, although it does seem like the future of this tool is uncertain. What do you think @sbueringer @furkatgofurov7 ?

Looks like Joe went ahead and just added the CRD references to their book rather than relying on the tool, so maybe this is a better path to invest time in?

@sbueringer
Copy link
Member

sbueringer commented Aug 25, 2023

I would probably continue to use docs.crds.dev if our only problem right now is the tag thing. We can always start generating the docs ourselves if it should go away.

Not sure if we should move ahead of time. I prefer the way that docs.crds.dev renders it.

@furkatgofurov7
Copy link
Member

I think giving a shot to change the current behavior in crdsdev/doc would be a first option considering it is not yet fully clear if the project will go away. If the change is rejected/can't be made or worst case project is taken down, we can re-evaluate and see other options like generating them ourselves at last.

@cahillsf
Copy link
Member Author

cahillsf commented Dec 7, 2023

Repo maintainer is not responding on the improvement to the tags behavior (have a FR and a draft PR - opened 4 months ago and bumped with no reply).

Going to close this out.

@cahillsf cahillsf closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release Issues or PRs related to releasing kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

No branches or pull requests

4 participants