Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tilt: allowing duplicated resources for addons/providers #9300

Closed
prometherion opened this issue Aug 24, 2023 · 3 comments · Fixed by #9302
Closed

Tilt: allowing duplicated resources for addons/providers #9300

prometherion opened this issue Aug 24, 2023 · 3 comments · Fixed by #9302
Labels
area/clusterctl Issues or PRs related to clusterctl kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@prometherion
Copy link
Contributor

What would you like to be added (User Story)?

As a CAPI provider developer I want to offer end-users a way to install multiple components by using the clusterctl file, such as:

These components are expected to be deployed in the same Namespace for logical grouping.

Detailed Description

With the said example, the two components are expected to be deployed in the same Namespace.

However, the Tiltfile used by clusterctl doesn't allow duplicates since allow_duplicates default value is false:

k8s_yaml(yaml)

Anything else you would like to add?

A similar use case is the following one: #6079 (comment)

Label(s) to be applied

/kind feature
/area clusterctl

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/clusterctl Issues or PRs related to clusterctl needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 24, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

Is the problem basically that in this case the Namespace object is duplicate?

In general if the only thing we have to do is to set allow_duplicates = True in l.371 I'm fine with making the change

@prometherion
Copy link
Contributor Author

Thanks, Stefan! I'm going to open the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants