Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tilt-prepare command doesn't check if the addons provider has already metrics port exposed #9306

Closed
prometherion opened this issue Aug 25, 2023 · 1 comment · Fixed by #9308
Labels
area/clusterctl Issues or PRs related to clusterctl kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@prometherion
Copy link
Contributor

What steps did you take and what happened?

I'm debugging locally CAPI along with a set of providers using Tilt by using the following file:

{
  "enable_providers": [
    "core",
    "kubeadm-bootstrap",
    "kamaji",
    "kamaji-core"
  ],
  "provider_repos": [
    "../../clastix/kamaji",
    "../../clastix/cluster-api-control-plane-provider-kamaji"
  ],
  "deploy_cert_manager": true,
  "trigger_mode": "manual",
  "kustomize_substitutions": {
    "EXP_CLUSTER_RESOURCE_SET": "true"
  }
}

The kamaji-core Kustomize manifest is already exporting a metrics port, however, the rendered manifest will end-up with a duplicate port, being impossible to setup the whole environment.

What did you expect to happen?

tilt-prepare should skip adding the ports item if the addon Deployment manifest is already offering a metrics port listening on 8080.

Cluster API version

v1.5.0

Kubernetes version

N.R.

Anything else you would like to add?

I already have a PR to fix this.

Label(s) to be applied

/kind bug
/area clusterctl

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/clusterctl Issues or PRs related to clusterctl needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 25, 2023
@sbueringer
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants