Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate new instances of context.TODO() from clusterctl proxy.go #9442

Closed
nojnhuh opened this issue Sep 15, 2023 · 9 comments · Fixed by #9776
Closed

Eliminate new instances of context.TODO() from clusterctl proxy.go #9442

nojnhuh opened this issue Sep 15, 2023 · 9 comments · Fixed by #9776
Labels
area/clusterctl Issues or PRs related to clusterctl triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@nojnhuh
Copy link
Contributor

nojnhuh commented Sep 15, 2023

Three new instances of context.TODO() have been introduced as a part of #9437. These should be removed in favor of utilizing existing contexts.

These are the locations of the instances:

if err := retryWithExponentialBackoff(context.TODO(), connectBackoff, func(_ context.Context) error {

return retryWithExponentialBackoff(context.TODO(), connectBackoff, func(_ context.Context) error {

if err := retryWithExponentialBackoff(context.TODO(), connectBackoff, func(_ context.Context) error {

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 15, 2023
@sbueringer
Copy link
Member

Thx for opening the issue

/triage accepted
/area clusterctl

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. area/clusterctl Issues or PRs related to clusterctl and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 18, 2023
@chiukapoor
Copy link
Contributor

chiukapoor commented Sep 22, 2023

I can work on this, please assign @sbueringer

@chrischdi
Copy link
Member

/assign chiukapoor

@chiukapoor
Copy link
Contributor

chiukapoor commented Sep 22, 2023

The PR #9437 has not merged yet which will get these changes to the main branch,

@chrischdi
Copy link
Member

Ah yeah, so I'll remove the assignment.

/unassign chiukapoor

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Nov 13, 2023

@chiukapoor The PR has been merged in case you're still looking to pick this up.

@mcbenjemaa
Copy link
Member

I will take this issue if he can't take it.

@sbueringer
Copy link
Member

@mcbenjemaa Feel free to take it, waiting 2 weeks is enough :)

@chiukapoor
Copy link
Contributor

@mcbenjemaa thank you for taking it over. I was away for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants