-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate new instances of context.TODO() from clusterctl proxy.go #9442
Comments
Thx for opening the issue /triage accepted |
I can work on this, please assign @sbueringer |
/assign chiukapoor |
The PR #9437 has not merged yet which will get these changes to the main branch, |
Ah yeah, so I'll remove the assignment. /unassign chiukapoor |
@chiukapoor The PR has been merged in case you're still looking to pick this up. |
I will take this issue if he can't take it. |
@mcbenjemaa Feel free to take it, waiting 2 weeks is enough :) |
@mcbenjemaa thank you for taking it over. I was away for a while. |
Three new instances of
context.TODO()
have been introduced as a part of #9437. These should be removed in favor of utilizing existing contexts.These are the locations of the instances:
cluster-api/cmd/clusterctl/client/cluster/proxy.go
Line 168 in 1779aec
cluster-api/cmd/clusterctl/client/cluster/proxy.go
Line 194 in 1779aec
cluster-api/cmd/clusterctl/client/cluster/proxy.go
Line 405 in 1779aec
The text was updated successfully, but these errors were encountered: