Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tool review permissions for release team #9524

Closed
g-gaston opened this issue Oct 4, 2023 · 5 comments · Fixed by #9563
Closed

Release tool review permissions for release team #9524

g-gaston opened this issue Oct 4, 2023 · 5 comments · Fixed by #9563
Assignees
Labels
area/release Issues or PRs related to releasing triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@g-gaston
Copy link
Contributor

g-gaston commented Oct 4, 2023

What would you like to be added (User Story)?

As the release team, we would like to able to review and merge change to the release tool by ourselves without depending on maintainers, speeding up the development cycle.

Detailed Description

We propose to add lgtm permissions for the release team and approve permissions for the release team leader, only for the release folder.

Follow up from #9500 (review)

@kubernetes-sigs/cluster-api-release-team

Anything else you would like to add?

No response

Label(s) to be applied

/kind proposal
/area release

@k8s-ci-robot k8s-ci-robot added kind/proposal Issues or PRs related to proposals. area/release Issues or PRs related to releasing needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 4, 2023
@killianmuldoon killianmuldoon removed the kind/proposal Issues or PRs related to proposals. label Oct 4, 2023
@killianmuldoon
Copy link
Contributor

/triage accepted

Thanks @g-gaston for proposing this. I'm strongly in favor. Giving more responsibility for release processes and tools is the right approach.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 4, 2023
@furkatgofurov7
Copy link
Member

Thanks for opening the issue.

I have no objections on the change either, as far as it speeds up processes and helps the release team.

@CecileRobertMichon
Copy link
Contributor

+1

@g-gaston
Copy link
Contributor Author

/assign

@sbueringer
Copy link
Member

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release Issues or PRs related to releasing triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants