Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for bootstrapping docker machine #9530

Closed
alexander-demicev opened this issue Oct 9, 2023 · 4 comments · Fixed by #9952
Closed

Increase timeout for bootstrapping docker machine #9530

alexander-demicev opened this issue Oct 9, 2023 · 4 comments · Fixed by #9952
Assignees
Labels
area/provider/bootstrap-kubeadm Issues or PRs related to CAPBK kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@alexander-demicev
Copy link
Contributor

alexander-demicev commented Oct 9, 2023

What would you like to be added (User Story)?

As a user I would like to give more time to the Docker machine to bootstrap when not using CAPBK.

Detailed Description

Currently, there is a 3 minute timeout for bootstrapping a Docker machine https://github.com/kubernetes-sigs/cluster-api/blob/main/test/infrastructure/docker/internal/controllers/dockermachine_controller.go#L307. We are using CAPD to test RKE2 bootstrap provider and it might take more than 3 minutes for bootstrap to succeed. We would like this timeout to be increased or made configurable.

cc @richardcase

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 9, 2023
@killianmuldoon
Copy link
Contributor

/triage accepted

I think making this configurable with a 3 minute timeout is a good solution here.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 9, 2023
@typeid
Copy link
Contributor

typeid commented Oct 10, 2023

I'd like to work on this :)

/assign

@sbueringer sbueringer added the area/provider/bootstrap-kubeadm Issues or PRs related to CAPBK label Nov 15, 2023
@salasberryfin
Copy link
Contributor

Since this has been stalled for a few months now, I'll be picking it up and pushing a PR with a proposal to make the timeout configurable.

@salasberryfin
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/bootstrap-kubeadm Issues or PRs related to CAPBK kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants