Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch for Cluster resource in topology owned MachineDeployment controller #9532

Closed
adityabhatia opened this issue Oct 9, 2023 · 2 comments
Closed

Watch for Cluster resource in topology owned MachineDeployment controller #9532

adityabhatia opened this issue Oct 9, 2023 · 2 comments
Labels
area/machinedeployment Issues or PRs related to machinedeployments kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@adityabhatia
Copy link
Contributor

What would you like to be added (User Story)?

As a user I would like to watch for the associated Cluster resource in the topology based MachineDeployment controller.
This watcher will ensure any changes on Cluster results in enqueuing a request for the corresponding MachineDeployment (and subsequently MachineSet), thereby resulting in faster reconciliations, which is not the case currently.

Detailed Description

This gap was noticed during the finalizers test implementation where MachineDeployments (and owned MachineSet) were not getting reconcilied when Finalizers on Cluster were re-set.

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
/area machinedeployment
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/machinedeployment Issues or PRs related to machinedeployments needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 9, 2023
@adityabhatia adityabhatia mentioned this issue Oct 9, 2023
Merged
@fabriziopandini
Copy link
Member

/triage accepted
cc @killianmuldoon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 9, 2023
@sbueringer
Copy link
Member

Sounds good for the case where we want a reconcile to be triggered after Cluster unpause.

@adityabhatia adityabhatia mentioned this issue Dec 12, 2023
Merged
@adityabhatia adityabhatia mentioned this issue Jan 21, 2024
Merged
@adityabhatia adityabhatia mentioned this issue Jan 26, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/machinedeployment Issues or PRs related to machinedeployments kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sbueringer @fabriziopandini @adityabhatia @k8s-ci-robot