Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate dualstack and e2e-full test jobs #9666

Closed
killianmuldoon opened this issue Nov 3, 2023 · 14 comments
Closed

Consolidate dualstack and e2e-full test jobs #9666

killianmuldoon opened this issue Nov 3, 2023 · 14 comments
Assignees
Labels
area/e2e-testing Issues or PRs related to e2e testing kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@killianmuldoon
Copy link
Contributor

Cluster API currently has two large e2e test runs - on main these are called [capi-e2e-main](https://github.com/kubernetes/test-infra/blob/b32aa0f189f4bc543753ce33f99ee88068dbfdaf/config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml#L70-L111) and [capi-e2e-dualstack-and-ipv6-main](https://github.com/kubernetes/test-infra/blob/b32aa0f189f4bc543753ce33f99ee88068dbfdaf/config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml#L112-L155C20).

capi-e2e-dualstack-and-ipv6-main runs everything from capi-e2e-main and additionally runs the CAPI quickstart with IPv6 as well as quick-start with dualstack tests for dualstack IPv4 primary and dualstack IPv6 primary.

We should consider de-duplicating these tests by running the current capi-e2e-dualstack-and-ipv6-main config under capi-e2e-main and removing the capi-e2e-dualstack-and-ipv6-main periodic and presubmit jobs.

Note: This can not be done before resolving #8816. That issue concerns flakes in the dualstack tests. These flakes signal that something is likely not right in our dualstack configuration.

@killianmuldoon
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 3, 2023
@sbueringer sbueringer added the area/e2e-testing Issues or PRs related to e2e testing label Nov 14, 2023
@fabriziopandini
Copy link
Member

/kind cleanup
/priority backlog

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Apr 11, 2024
@sbueringer
Copy link
Member

@chrischdi @killianmuldoon After #8816 has been fixed. Should we consider this issue again?

@sbueringer
Copy link
Member

IIRC this would basically mean we'll use the dualstack job config for e2e-main and delete the dualstack job

@killianmuldoon
Copy link
Contributor Author

Yeah IMO we should go ahead and do this

@killianmuldoon
Copy link
Contributor Author

/assign

@sbueringer
Copy link
Member

Just to surface this here as well. #10135 is merged, we should be now unblocked to continue this issue

@sbueringer sbueringer added this to the v1.8 milestone Apr 18, 2024
@killianmuldoon
Copy link
Contributor Author

Started taking a look at this - do we want to remove the seperate ipv6 jobs on presubmits? Do we want to make the change for all branches? i.e. 1.5, 1.6, 1.7, main.

Getting used to the prowjob generator - great work on that @chrischdi

@sbueringer
Copy link
Member

I would merge the ipv6 and the regular job, which IIRC basically means keeping the ipv6 job with the name of the other job.

I don't remember the exact fixes and how far we backported them. Ideally we would merge the jobs for all branches that are now stable (@chrischdi can probably provide more info on that)

@chrischdi
Copy link
Member

The fix got cherry-picked back to 1.5, so should be on all relevant branches.

I think we can use k8s-triage to compare two jobs we want to merge, to see if there errors are ~ the same or different.

Or used the combined query: https://storage.googleapis.com/k8s-triage/index.html?job=.*-cluster-api-e2e-dualstack-and-ipv6-main%7C.*-cluster-api-e2e-main

@killianmuldoon
Copy link
Contributor Author

kubernetes/test-infra#32545

Should be ready for review now

@sbueringer
Copy link
Member

sbueringer commented May 8, 2024

Just want to want to emphasize. Thx @killianmuldoon @chrischdi for all the work on initially making IPv6 work until now getting rid of the separate IPv6 jobs!

@sbueringer
Copy link
Member

@killianmuldoon @chrischdi I think this is done

@killianmuldoon
Copy link
Contributor Author

Yeah this is done - closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/e2e-testing Issues or PRs related to e2e testing kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants