Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requeues in DockerMachinePool implementation #9724

Open
Jont828 opened this issue Nov 15, 2023 · 3 comments
Open

Remove requeues in DockerMachinePool implementation #9724

Jont828 opened this issue Nov 15, 2023 · 3 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Jont828
Copy link
Contributor

Jont828 commented Nov 15, 2023

What would you like to be added (User Story)?

In #8842, we would ideally like to remove the need to requeue to check if all dependent objects are deleted, and the requeue to check if the DockerMachines are ready. Instead, we would like to set up a Watch() on DockerMachines and ensure they have an ownerRef to DockerMachinePools.

Detailed Description

N/A

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 15, 2023
@Jont828
Copy link
Contributor Author

Jont828 commented Nov 15, 2023

/assign @CecileRobertMichon

@sbueringer
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 16, 2023
@fabriziopandini
Copy link
Member

/priority backlog
/remove kind-feature
/kind cleanup

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Apr 11, 2024
@fabriziopandini fabriziopandini removed the kind/feature Categorizes issue or PR as related to a new feature. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants