Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fish completion for clusterctl #9913

Closed
kranurag7 opened this issue Dec 20, 2023 · 1 comment · Fixed by #9950
Closed

Support fish completion for clusterctl #9913

kranurag7 opened this issue Dec 20, 2023 · 1 comment · Fixed by #9950
Assignees
Labels
area/clusterctl Issues or PRs related to clusterctl kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@kranurag7
Copy link
Contributor

kranurag7 commented Dec 20, 2023

What would you like to be added (User Story)?

As of now, clusterctl doesn't support fish shell completion. I mostly use fish shell and would like to have completion for fish shell as well.

We use cobra under the hood and other cobra based CLIs, including kubectl support completion for fish shell.
Ref: https://pkg.go.dev/github.com/spf13/cobra#Command.GenFishCompletion

Detailed Description

$ clusterctl completion fish
Error: unsupported shell type "fish"

Anything else you would like to add?

I'll be happy to create a patch once it's triaged.

Label(s) to be applied

/kind feature
/area clusterctl
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 20, 2023
@fabriziopandini
Copy link
Member

/triage accepted
/assign @kranurag7
/area clusterctl

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. area/clusterctl Issues or PRs related to clusterctl and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants