Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsonpatch go module #1217

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

ncdc
Copy link
Contributor

@ncdc ncdc commented Aug 1, 2019

What this PR does / why we need it:
Fix an issue in go.sum with the jsonpatch module checksum

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2019
@ncdc
Copy link
Contributor Author

ncdc commented Aug 1, 2019

@cblecker @BenTheElder is this the right thing to do?

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 1, 2019
@ncdc
Copy link
Contributor Author

ncdc commented Aug 1, 2019

/retest

hack/update-vendor.sh Outdated Show resolved Hide resolved
Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
@ncdc ncdc force-pushed the fix-jsonpatch-go-mod branch from e7698c3 to c31a7c8 Compare August 1, 2019 13:59
Copy link
Member

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 83d4c2a into kubernetes-sigs:master Aug 1, 2019
@ncdc ncdc deleted the fix-jsonpatch-go-mod branch September 6, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants