From ebbf336d12b80676e12b71768a4c6ccafe69bee6 Mon Sep 17 00:00:00 2001 From: Kazuki Suda Date: Tue, 19 Mar 2019 13:44:10 +0900 Subject: [PATCH 1/2] Fix a dead link to examples --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5b9f276fde..0e02f8a9c7 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,7 @@ Documentation: - [Basic controller using builder](https://godoc.org/github.com/kubernetes-sigs/controller-runtime/pkg/builder#example-Builder) - [Creating a manager](https://godoc.org/github.com/kubernetes-sigs/controller-runtime/pkg/manager#example-New) - [Creating a controller](https://godoc.org/github.com/kubernetes-sigs/controller-runtime/pkg/controller#example-New) -- [Example `main.go`](https://github.com/kubernetes-sigs/controller-runtime/blob/master/example/main.go) +- [Examples](https://github.com/kubernetes-sigs/controller-runtime/blob/master/examples) # Versioning, Maintenance, and Compatibility From 56dd24c7be91544e0ee62fc66a43201965e24865 Mon Sep 17 00:00:00 2001 From: Mateusz Szostok Date: Mon, 1 Apr 2019 19:13:15 +0200 Subject: [PATCH 2/2] Fix used scheme for fake client in List method --- pkg/client/fake/client.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/client/fake/client.go b/pkg/client/fake/client.go index b85e18c696..a433190c6a 100644 --- a/pkg/client/fake/client.go +++ b/pkg/client/fake/client.go @@ -93,7 +93,7 @@ func (c *fakeClient) Get(ctx context.Context, key client.ObjectKey, obj runtime. } func (c *fakeClient) List(ctx context.Context, obj runtime.Object, opts ...client.ListOptionFunc) error { - gvk, err := apiutil.GVKForObject(obj, scheme.Scheme) + gvk, err := apiutil.GVKForObject(obj, c.scheme) if err != nil { return err }