From 29b471a2381c8b792d03e7d38d0da3208600254a Mon Sep 17 00:00:00 2001 From: Joel Speed Date: Tue, 9 Apr 2019 10:06:04 +0100 Subject: [PATCH] Don't use pointer for sync.Mutex --- pkg/log/deleg.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/log/deleg.go b/pkg/log/deleg.go index c6af8ac6ee..949117f6bb 100644 --- a/pkg/log/deleg.go +++ b/pkg/log/deleg.go @@ -27,7 +27,7 @@ import ( type loggerPromise struct { logger *DelegatingLogger childPromises []*loggerPromise - promisesLock *sync.Mutex + promisesLock sync.Mutex name *string tags []interface{} @@ -38,7 +38,7 @@ func (p *loggerPromise) WithName(l *DelegatingLogger, name string) *loggerPromis res := &loggerPromise{ logger: l, name: &name, - promisesLock: &sync.Mutex{}, + promisesLock: sync.Mutex{}, } p.promisesLock.Lock() @@ -52,7 +52,7 @@ func (p *loggerPromise) WithValues(l *DelegatingLogger, tags ...interface{}) *lo res := &loggerPromise{ logger: l, tags: tags, - promisesLock: &sync.Mutex{}, + promisesLock: sync.Mutex{}, } p.promisesLock.Lock() @@ -130,7 +130,7 @@ func (l *DelegatingLogger) Fulfill(actual logr.Logger) { func NewDelegatingLogger(initial logr.Logger) *DelegatingLogger { l := &DelegatingLogger{ Logger: initial, - promise: &loggerPromise{promisesLock: &sync.Mutex{}}, + promise: &loggerPromise{promisesLock: sync.Mutex{}}, } l.promise.logger = l return l