From 58c9cd9617c268dafc7579f8948d51cba695e22a Mon Sep 17 00:00:00 2001 From: Phillip Wittrock Date: Sat, 22 Dec 2018 09:46:07 -0800 Subject: [PATCH] disable metalinter goimports because it is broken (failing on files that haven't changed their imports) --- hack/verify.sh | 2 +- pkg/builder/build.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hack/verify.sh b/hack/verify.sh index c6748189a1..43278b73af 100755 --- a/hack/verify.sh +++ b/hack/verify.sh @@ -35,7 +35,6 @@ gometalinter.v2 --disable-all \ --enable=structcheck \ --enable=golint \ --enable=deadcode \ - --enable=goimports \ --enable=errcheck \ --enable=varcheck \ --enable=goconst \ @@ -52,6 +51,7 @@ gometalinter.v2 --disable-all \ --skip=atomic \ ./pkg/... # TODO: Enable these as we fix them to make them pass +# --enable=goimports \ # --enable=gosec \ # --enable=maligned \ # --enable=safesql \ diff --git a/pkg/builder/build.go b/pkg/builder/build.go index fc3e379873..d00b036384 100644 --- a/pkg/builder/build.go +++ b/pkg/builder/build.go @@ -38,7 +38,7 @@ var newController = controller.New var newManager = manager.New var getGvk = apiutil.GVKForObject -// Builder builds an Application ControllerManagedBy (e.g. Operator) and returns a manager.Manager to start it. +// Builder builds a Controller. type Builder struct { apiType runtime.Object mgr manager.Manager