From 7b28fd8a600701c6afa0da57d7db60251cf1c51f Mon Sep 17 00:00:00 2001 From: Alexander Zielenski <351783+alexzielenski@users.noreply.github.com> Date: Thu, 14 Apr 2022 14:38:27 -0700 Subject: [PATCH] fixup! add new cache.Options field to customize transform attempt to fix race introduced in test by not referring to modified variable within callback --- pkg/cache/cache_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/cache/cache_test.go b/pkg/cache/cache_test.go index 59f84815ca..fff2dead43 100644 --- a/pkg/cache/cache_test.go +++ b/pkg/cache/cache_test.go @@ -167,13 +167,14 @@ var _ = Describe("Cache with transformers", func() { }) BeforeEach(func() { - transformerHits = make(chan struct{}, 10) + hitsChan := make(chan struct{}, 10) var err error var transform = func(i interface{}) (interface{}, error) { - transformerHits <- struct{}{} + hitsChan <- struct{}{} return i, nil } + transformerHits = hitsChan clien, err = client.New(cfg, client.Options{}) Expect(err).NotTo(HaveOccurred())