From 98e5915559f21a83198455608d4e09f7f8d91d54 Mon Sep 17 00:00:00 2001 From: Alena Varkockova Date: Wed, 22 Jan 2020 11:30:46 +0100 Subject: [PATCH] Remove references to 'download-binaries.sh' --- pkg/internal/testing/integration/assets/bin/.gitkeep | 2 +- pkg/internal/testing/integration/doc.go | 9 +-------- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/pkg/internal/testing/integration/assets/bin/.gitkeep b/pkg/internal/testing/integration/assets/bin/.gitkeep index 172cb3f183..368201aa28 100644 --- a/pkg/internal/testing/integration/assets/bin/.gitkeep +++ b/pkg/internal/testing/integration/assets/bin/.gitkeep @@ -1 +1 @@ -This directory will be the home of some binaries which are downloaded with `pkg/framework/test/scripts/download-binaries`. +This directory will be the home of some binaries which are downloaded with `make test` or `.../hack/check-everything.sh`. diff --git a/pkg/internal/testing/integration/doc.go b/pkg/internal/testing/integration/doc.go index bbd88d94a9..62a0367311 100644 --- a/pkg/internal/testing/integration/doc.go +++ b/pkg/internal/testing/integration/doc.go @@ -8,9 +8,7 @@ needed to provide this API is managed by this framework. Quickstart -If you want to test a kubernetes client against the latest kubernetes APIServer -and Etcd, you can use `./scripts/download-binaries.sh` to download APIServer -and Etcd binaries for your platform. Then add something like the following to +Add something like the following to your tests: cp := &integration.ControlPlane{} @@ -71,11 +69,6 @@ APIServer, Etcd or KubeCtl. framework tries to use the binaries `kube-apiserver`, `etcd` or `kubectl` in the directory `${FRAMEWORK_DIR}/assets/bin/`. -For convenience this framework ships with -`${FRAMEWORK_DIR}/scripts/download-binaries.sh` which can be used to download -pre-compiled versions of the needed binaries and place them in the default -location (`${FRAMEWORK_DIR}/assets/bin/`). - Arguments for Etcd and APIServer Those components will start without any configuration. However, if you want or