From b3610e8b8659961907a2081d503fb74cc556894e Mon Sep 17 00:00:00 2001 From: Solly Ross Date: Mon, 3 Dec 2018 17:38:02 -0800 Subject: [PATCH] :running: Mark pending tests as pending This marks tests that have a "// TODO: write this" or similar as pending tests, so that we can keep track of them. --- pkg/internal/controller/controller_test.go | 14 +++++++------- pkg/source/source_integration_test.go | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/pkg/internal/controller/controller_test.go b/pkg/internal/controller/controller_test.go index 6ff161d54d..bc83d4f84b 100644 --- a/pkg/internal/controller/controller_test.go +++ b/pkg/internal/controller/controller_test.go @@ -176,11 +176,11 @@ var _ = Describe("controller", func() { Expect(ctrl.Watch(src, evthdl)).To(Equal(expected)) }) - It("should inject dependencies into the Reconciler", func() { + PIt("should inject dependencies into the Reconciler", func() { // TODO(community): Write this }) - It("should return an error if there is an error injecting into the Reconciler", func() { + PIt("should return an error if there is an error injecting into the Reconciler", func() { // TODO(community): Write this }) @@ -299,7 +299,7 @@ var _ = Describe("controller", func() { close(done) }) - It("should forget an item if it is not a Request and continue processing items", func() { + PIt("should forget an item if it is not a Request and continue processing items", func() { // TODO(community): write this test }) @@ -391,19 +391,19 @@ var _ = Describe("controller", func() { Eventually(func() int { return ctrl.Queue.NumRequeues(request) }).Should(Equal(0)) }) - It("should forget the Request if Reconciler is successful", func() { + PIt("should forget the Request if Reconciler is successful", func() { // TODO(community): write this test }) - It("should return if the queue is shutdown", func() { + PIt("should return if the queue is shutdown", func() { // TODO(community): write this test }) - It("should wait for informers to be synced before processing items", func() { + PIt("should wait for informers to be synced before processing items", func() { // TODO(community): write this test }) - It("should create a new go routine for MaxConcurrentReconciles", func() { + PIt("should create a new go routine for MaxConcurrentReconciles", func() { // TODO(community): write this test }) diff --git a/pkg/source/source_integration_test.go b/pkg/source/source_integration_test.go index 40064d24ce..dec9230d69 100644 --- a/pkg/source/source_integration_test.go +++ b/pkg/source/source_integration_test.go @@ -206,7 +206,7 @@ var _ = Describe("Source", func() { }) // TODO(pwittrock): Write this test - Context("for a Foo CRD resource", func() { + PContext("for a Foo CRD resource", func() { It("should provide Foo Events", func() { })