event predicates logic optimization

[cuisongliu]

controller-runtime/pkg/source/internal/eventsource.go

Line 117 in 4836ec2

for _, p := range e.Predicates {

this code design is “and” logic。 but I think "or" logic is better?

       var flag bool
       for _, p := range e.Predicates {
		if p.Create(c) {
			flag = true
                        break
		} 
	}
       
        if flag{
             // Invoke create handler
	     e.EventHandler.Create(c, e.Queue)
        }

• all false result is false;
• has one true result is true

[cuisongliu]

/assign

[cuisongliu]

/kind feature

[vincepri]

Can we rely on the Or functionality that we now have in #1043

/milestone Next
/priority awaiting-more-evidence

[cuisongliu]

yes, I want this logic. thank.