We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I came across a couple of bugs in the log.FromContext function:
log.FromContext
logr.Logger
keysAndValues
WithValues
I have a patch that should address these here: master...charithe:fix/logging-ctx
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
I came across a couple of bugs in the
log.FromContext
function:logr.Logger
-- which causes a panic.keysAndValues
argument has no effect because the logger returned from theWithValues
method is ignored in the return value.I have a patch that should address these here: master...charithe:fix/logging-ctx
The text was updated successfully, but these errors were encountered: