Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus metrics #119

Closed
JoelSpeed opened this issue Aug 24, 2018 · 1 comment
Closed

Prometheus metrics #119

JoelSpeed opened this issue Aug 24, 2018 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@JoelSpeed
Copy link
Contributor

I would like to add prometheus metrics to the controllers I'm building using kubebuilder.

It would be good to have information both from the controller internals themselves as well as from the reconciler loops I'm implementing.

My initial idea is to add a prometheus metric registry to the controller manager that it can use itself and can be used by reconcil.Reconcilers to register their own metrics. Then have the controller manager start the metrics server when Start is called.

Does this seem reasonable or should people just handle metrics on their own? PR welcome?

@DirectXMan12
Copy link
Contributor

PRs definitely welcome. We already have some metrics that we inherit from the underlying apimachinery, but PRs are definitely welcome to improve this!

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants