pkg/log/zap: development option not turning on debug logging

[estroz]

controller-runtime v0.6.3

Setting pkg/log/zap.Options.Development = true then constructing a zap logger using the prescribed code doesn't seem to turn on debug logging (or development mode at all).

The old way (main.go):

var logger = ctrl.Log.WithName("setup")

func main() {
	ctrl.SetLogger(zap.New(zap.UseDevMode(true)))
	logger.V(1).Info("running in debug")
}

Then:

$ go run main.go
2020-10-26T16:32:04.135-0700	DEBUG	setup	running in debug

The new way (main.go):

var logger = ctrl.Log.WithName("setup")

func main() {
	opts := &zap.Options{Development: true}
	opts.BindFlags(flag.CommandLine)
	flag.Parse()
	ctrl.SetLogger(zap.New(zap.UseFlagOptions(opts)))
    logger.V(1).Info("running in debug")
}

Then:

$ go run main.go # no output

But if I set --zap-log-level=debug explicitly:

$ go run main.go --zap-log-level=debug
{"level":"debug","ts":1603755159.9834673,"logger":"setup","msg":"running in debug"}

Note how the output is JSON, which is the default production output encoding; development should give console output according to the docs.

And if I set --zap-devel explicitly:

$ go run main.go --zap-devel
2020-10-26T16:44:42.638-0700	DEBUG	setup	running in debug

/kind bug

/ping @joelanford @DirectXMan12

[estroz]

This looks like it was fixed by #972.